Raise ratelimit user friendly and other network errors. #1109 #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhargavh
changed the title
bhargavh
changed the title
bhargavh
changed the title
|
Looks interesting! Could you also print the http error as well so that the user can see it? |
Codecov Report
@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 86.67% 86.61% -0.06%
==========================================
Files 181 181
Lines 3016 3025 +9
Branches 333 334 +1
==========================================
+ Hits 2614 2620 +6
- Misses 320 322 +2
- Partials 82 83 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small PR that will give better readable errors when the user is ratelimited and also raise on error wherever a request happens , Sorry if I did it wrong. Please CR and tell me any feedback
Regards.